fix: add missing parameters for --updateService - #143
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the --updateService rollout path to include additional ecs:UpdateService/ecs:CreateService parameters (notably capacity provider and placement-related fields), and centralizes the “copy service definition fields into UpdateServiceInput” logic into a single helper with accompanying unit tests.
Changes:
- Extend the ECS test server mock to store additional
CreateService/UpdateServicefields (capacity provider strategy, placement constraints/strategy). - Introduce
applyServiceDefinitionToUpdateInputto copy service definition fields intoecs.UpdateServiceInputand use it from the rollout executor. - Add unit tests for the helper and an integration-style test for nil slice behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/ecs.go |
Mock ECS server updated to capture additional service fields during create/update. |
rollout/service_sync.go |
New helper to apply service definition fields to an UpdateService request. |
rollout/service_sync_test.go |
Unit tests covering nil vs empty slice preservation in the helper. |
rollout/executor.go |
Switch to helper to populate UpdateServiceInput when --updateService is set. |
rollout/executor_test.go |
Update expected UpdateServiceInput fields for the --updateService path. |
rollout_test.go |
Add integration-style test around nil optional slice handling during --updateService. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
keroxp
marked this pull request as ready for review
June 2, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted newly introduced parameters of
ecs:UpdateService/ecs:CreateService.